On Tue, Dec 10, 2024 at 10:30:54PM +0530, Raj Kumar Bhagat wrote: > On 12/10/2024 8:13 PM, Krzysztof Kozlowski wrote: > > On 10/12/2024 08:41, Raj Kumar Bhagat wrote: > >> + case CALDB_MEM_REGION_TYPE: > >> + /* Cold boot calibration is not enabled in Ath12k. Hence, > >> + * assign paddr = 0. > >> + * Once cold boot calibration is enabled add support to > >> + * assign reserved memory from DT. > >> + */ > >> + ab->qmi.target_mem[idx].paddr = 0; > >> + ab->qmi.target_mem[idx].v.ioaddr = NULL; > >> + ab->qmi.target_mem[idx].size = ab->qmi.target_mem[i].size; > >> + ab->qmi.target_mem[idx].type = ab->qmi.target_mem[i].type; > >> + idx++; > >> + break; > >> + case M3_DUMP_REGION_TYPE: > >> + dev_node = of_find_node_by_name(NULL, "m3_dump"); > > > > NAK > > > > That's neither correct name nor documented in the bindings. You created > > now undocumented ABI. Even with incorrect name. :/ > > > > Most of the Device Tree related concern in this series are from the > undocumented ABIs and wrong naming (use of '_' instead of '-'): > "m3_dump" and "mlo_global_mem_0". > > To address the undocumented ABIs, "memory-region" and "memory-region-names" > should be used to reference all the reserved memory required. This should > include "m3_dump" and "mlo_global_mem_0" memory region. You already use them, so this code here and explanation is confusing. > > If the above approach valid to address undocumented ABIs? Dunno. Change all node names, run dtbs_check. Do you see errors? Now run your driver. Does it work correctly? If yes, then ABI seems documented. If not, ABI is not documented. Best regards, Krzysztof
