On 10/12/2024 08:41, Raj Kumar Bhagat wrote:
> + case CALDB_MEM_REGION_TYPE:
> + /* Cold boot calibration is not enabled in Ath12k. Hence,
> + * assign paddr = 0.
> + * Once cold boot calibration is enabled add support to
> + * assign reserved memory from DT.
> + */
> + ab->qmi.target_mem[idx].paddr = 0;
> + ab->qmi.target_mem[idx].v.ioaddr = NULL;
> + ab->qmi.target_mem[idx].size = ab->qmi.target_mem[i].size;
> + ab->qmi.target_mem[idx].type = ab->qmi.target_mem[i].type;
> + idx++;
> + break;
> + case M3_DUMP_REGION_TYPE:
> + dev_node = of_find_node_by_name(NULL, "m3_dump");
NAK
That's neither correct name nor documented in the bindings. You created
now undocumented ABI. Even with incorrect name. :/
> + if (!dev_node || of_address_to_resource(dev_node, 0, &m3_res)) {
> + ath12k_err(ab, "m3_dump not defined in device-tree\n");
> + ret = -EINVAL;
> + goto out;
> + }
> +
Best regards,
Krzysztof
