On Wed, Dec 11, 2024 at 12:16:02AM +0200, Vladimir Oltean wrote: > On Tue, Dec 10, 2024 at 09:59:04PM +0100, Christian Marangi wrote: > > > > + airoha,ext-surge: > > > > + $ref: /schemas/types.yaml#/definitions/flag > > > > + description: > > > > + Calibrate the internal PHY with the calibration values stored in EFUSE > > > > + for the r50Ohm values. > > > > > > Doesn't seem that this pertains to the switch. > > > > Do you think this should be placed in each PHY node? > > Logically speaking, that's where it belongs. > > > I wanted to prevent having to define a schema also for PHY if possible > > given how integrated these are. (originally it was defined in DT node > > to follow how it was done in Airoha SDK) > > Does compatibility with the Airoha SDK dt-bindings matter in any way? No it doesn't, the requirement for nvmem already deviates a lot so changes are needed anyway. -- Ansuel
