On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> wrote: > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 > are actually powered by &vreg_l2j_1p2. > > Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies from > the x1e80100-crd device tree, assume that the fix also applies here. Though I can't verify schematics (perhaps Laurentiu can?), can confirm USBs still work as expected with this change. Tested-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > index b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a43adec291a31f9beed 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy { > }; > > &usb_1_ss0_qmpphy { > - vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-phy-supply = <&vreg_l2j_1p2>; > vdda-pll-supply = <&vreg_l1j_0p9>; > > status = "okay"; > @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy { > }; > > &usb_1_ss1_qmpphy { > - vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-phy-supply = <&vreg_l2j_1p2>; > vdda-pll-supply = <&vreg_l2d_0p9>; > > status = "okay"; > > -- > 2.47.0 >