Hello Dikshita, On Tue, 10 Dec 2024 at 12:05, Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> wrote: > > Introduce support for Qualcomm new video acceleration hardware i.e. > iris, used for video stream decoding. > > Iris is a multi pipe based hardware that offloads video stream decoding > from the application processor (AP). It supports H.264 decoding. The AP > communicates with hardware through a well defined protocol, called as > host firmware interface (HFI), which provides fine-grained and > asynchronous control over individual hardware features. > > This driver implements upgraded HFI gen2 to communicate with firmware. > It supports SM8550 which is based out of HFI gen 2. It also supports > SM8250 which is based out of HFI gen1. > > This driver comes with below capabilities: > - V4L2 complaint video driver with M2M and STREAMING capability. > - Supports H264 decoder. > > This driver comes with below features: > - Centralized resource management. > - Centralized management of core and instance states. > - Defines platform specific capabilities and features. As a results, it > provides a single point of control to enable/disable a given feature > depending on specific platform capabilities. > - Handles various video recommended sequences, like DRC, Drain, Seek, > EOS. > - Implements asynchronous communication with hardware to achieve better > experience in low latency usecases. > - Output and capture planes are controlled independently. Thereby > providing a way to reconfigure individual plane. > - Native hardware support of LAST flag which is mandatory to align with > port reconfiguration and DRAIN sequence as per V4L guidelines. [...] > > To: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> > To: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > To: Rob Herring <robh@xxxxxxxxxx> > To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> > To: Conor Dooley <conor+dt@xxxxxxxxxx> > To: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Cc: Hans Verkuil <hverkuil@xxxxxxxxx> > Cc: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> > Cc: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > Cc: Nicolas Dufresne <nicolas@xxxxxxxxxxxx> > Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > Cc: Jianhua Lu <lujianhua000@xxxxxxxxx> > Cc: Stefan Schmidt <stefan.schmidt@xxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> With my few pending questions and remarks taken into account you can add my Tested-by: Stefan Schmidt <stefan.schmidt@xxxxxxxxxx> # x1e80100 (Dell XPS 13 9345) Reviewed-by: Stefan Schmidt <stefan.schmidt@xxxxxxxxxx> for the full series. regards Stefan Schmidt