On Sat, Dec 07, 2024 at 09:00:32AM +0100, Oleksij Rempel wrote: > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + - ethernet-phy-id2000.0181 > > > > > > > > There's nothing specific here, can someone remind me why the generic > > > > binding is not enough? > > > > > > The missing binding was blamed by checkpatch. Haw should I proceed with this > > > patch? > > > > Does dtbs_check complain when you use it in a dts? What you have here > > matches against the pattern ^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$ > > so I think it won't. checkpatch might be too dumb to evaluate the regex? > > dtbs_check didn't complained about it, only checkpatch. Checkpatch is not a reason to add bindings. Missing binding would be a reason (e.g. pointed out by dtschema), but I understand this is not the case here, so drop the patch. Best regards, Krzysztof