On Thu, 05 Dec 2024 18:22:11 +0800, Cheng Jiang wrote: > Expand the firmware-name property to specify the names of NVM and > rampatch firmware to load. This update will support loading specific > firmware (nvm and rampatch) for certain chips, like the QCA6698 > Bluetooth chip, which shares the same IP core as the WCN6855 but has > different RF components and RAM sizes, requiring new firmware files. > > We might use different connectivity boards on the same platform. For > example, QCA6698-based boards can support either a two-antenna or > three-antenna solution, both of which work on the sa8775p-ride platform. > Due to differences in connectivity boards and variations in RF > performance from different foundries, different NVM configurations are > used based on the board ID. > > So In firmware-name, if the NVM file has an extension, the NVM file will > be used. Otherwise, the system will first try the .bNN (board ID) file, > and if that fails, it will fall back to the .bin file. > > Possible configurations: > firmware-name = "QCA6698/hpnv21.bin", "QCA6698/hpbtfw21.tlv"; > firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv"; > firmware-name = "QCA6698/hpnv21.bin"; > > Signed-off-by: Cheng Jiang <quic_chejiang@xxxxxxxxxxx> > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ > 1 file changed, 2 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml:106:5: [error] duplication of key "description" in mapping (key-duplicates) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml: ignoring, error parsing file ./Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml:106:5: found duplicate key "description" with value "specify the name of rampatch firmware to load" (original value: "specify the name of nvm firmware to load") make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dts' Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml:106:5: found duplicate key "description" with value "specify the name of rampatch firmware to load" (original value: "specify the name of nvm firmware to load") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241205102213.1281865-2-quic_chejiang@xxxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
