Am 3. Dezember 2024 10:40:35 MEZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>: >Il 02/12/24 13:25, Frank Wunderlich ha scritto: >> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >> > >arm64: dts: mediatek: mt7988a-bpi-r4: Add MediaTek MT6682A/RT5190A PMIC > >The BananaPi R4 board has a MediaTek MT8862A PMIC, a rebrand of the >Richtek RT5190A chip, connected to the I2C0 bus. > >Add the relevant node and, while at it, also configure the regulators >from this PMIC that are used on this board. > >> Bananapi R4 Board contains a MT6682A pmic which is compatible to rt5190a. >> Add its node to the i2 controller. >> >> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >> --- >> .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts >> index 13ca016d6a67..bc1ec73b8ddd 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts >> @@ -2,6 +2,8 @@ >> /dts-v1/; >> +#include <dt-bindings/regulator/richtek,rt5190a-regulator.h> >> + >> #include "mt7988a.dtsi" >> / { >> @@ -65,6 +67,55 @@ &i2c0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&i2c0_pins>; >> status = "okay"; >> + >> + rt5190a_64: rt5190a@64 { >> + compatible = "richtek,rt5190a"; >> + reg = <0x64>; >> + vin2-supply = <&rt5190_buck1>; >> + vin3-supply = <&rt5190_buck1>; >> + vin4-supply = <&rt5190_buck1>; >> + >> + regulators { >> + rt5190_buck1: buck1 { >> + regulator-name = "rt5190a-buck1"; >> + regulator-min-microvolt = <5090000>; >> + regulator-max-microvolt = <5090000>; >> + regulator-allowed-modes = >> + <RT5190A_OPMODE_AUTO RT5190A_OPMODE_FPWM>; > >Does it work like that? > >regulator-allowed-modes = <RT5190A_OPMODE_AUTO>, > <RT5190A_OPMODE_FPWM>; It seems working, dtbs_check accepts it and i can boot up with this change and see no errors caused by it. >If yes, please write it like that - if not, I'm sad - but regardless > >Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > regards Frank