On 12/3/2024 12:37 PM, Jens Glathe wrote:
On 03.12.24 06:08, Krishna Kurapati wrote:
[...]
Although functionally unused, there is one more connector node that
runs between QMPPHY and DWC3 node. For example in [1], please check
"usb_dp_qmpphy_usb_ss_in" and "usb_1_dwc3_ss"
Would be good to check why it is missing and add it further.
[1]:
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
I checked, there's an extra endpoint for usb_?_qmpphy_usb_ss_in and
usb_?_qmpphy_dp_in. usb_?_qmpphy_usb_ss_in are defined (and "wired")
between port@1 of usb_?_qmpphy and port@1 of usb_?_dwc3, in
sc8280xp.dtsi. On port@2 of the qmpphy is usb_?_qmpphy_dp_in as
endpoint, which is further defined in sc8280xp-microsoft-blackrock.dts
as connecting to mdss0_dp?_out. Maybe that's wrong, it's the same as in
sc8280xp-lenvo-thinkpad-x13s.dts.
You are right.
Ignore my comment, that node is specified in the base dtsi file for
sc8280xp.
From usb pov, your code looks good.
Thanks,
Krishna,
