On Wed, Nov 27, 2024 at 05:42:17PM +0100, Frieder Schrempf wrote: > From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> > > This reverts commit 27866e3e8a7e93494f8374f48061aa73ee46ceb2. > > It turned out that this feature was implemented based on > the wrong assumption that the SD_VSEL signal needs to be > controlled as GPIO in any case. > > In fact the straight-forward approach is to mux the signal > as USDHC_VSELECT and let the USDHC controller do the job. > > Most users never even used this property and the few who > did have been or are getting migrated to the alternative > approach. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> > --- > Changes for v2: > * split revert into separate patch > --- > .../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml > index f8057bba747a5..79fc0baf5fa2f 100644 > --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml > @@ -77,11 +77,6 @@ properties: > > additionalProperties: false > > - sd-vsel-gpios: > - description: GPIO that is used to switch LDO5 between being configured by > - LDO5CTRL_L or LDO5CTRL_H register. Use this if the SD_VSEL signal is > - connected to a host GPIO. Your driver side of this, that I wasn't sent and cba downloading an mbox of is not backwards compatible. The code has been there for a few years, are you sure that there are no out of tree users or other OSes that use the property? tbh, I think all 3 of your dt-binding patches should be squashed rather than drip-feeding the conversion. It makes more sense as a single change, rather than splitting the rationales across 3 patches.
Attachment:
signature.asc
Description: PGP signature
