Hi Conor, Thanks for your review. On Wed, 2024-11-27 at 16:02 +0000, Conor Dooley wrote: > On Wed, Nov 27, 2024 at 04:00:59PM +0000, Conor Dooley wrote: > > On Wed, Nov 27, 2024 at 10:58:12AM +0000, André Draszik wrote: > > > orientation-switch is the standard declaration to inform the Type-C > > > mux > > > layer that a remote-endpoint is capable of processing orientation > > > change messages. > > > > > > Add as an optional since not all versions of this phy currently > > > support > > > or even need the orientation-switch. > > > > > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> > > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Actually, this patch unconditionally adds the property to the binding. > Is it valid for !gs101? Good point. I've only made it required for gs101 in the next patch, but as- is, somebody could still add it (in error) in !gs101 cases. I guess it's best to squash patches 3 and 4 in that case, and update it to disallow for !gs101. Thanks, Andre'