On Wed, Nov 27, 2024 at 04:56:13PM +0100, Sean Nyekjaer wrote: > Hi Conor, > > On Wed, Nov 27, 2024 at 03:50:30PM +0100, Conor Dooley wrote: > > On Wed, Nov 27, 2024 at 02:40:47PM +0100, Sean Nyekjaer wrote: > > > tcan4x5x requires an external clock called cclk, add it here. > > > > That's not what this patch is doing, the clock input is already there, > > so I don't know what this patch actually accomplishes? clock-names isn't > > a required property, so you can't even use it in a driver. > > > > Thanks for asking the right questions :) > > I know the clock input is there, but it looks (to me) like the driver looks for the > specific clock called cclk: > https://elixir.bootlin.com/linux/v6.12/source/drivers/net/can/m_can/m_can.c#L2299 > https://elixir.bootlin.com/linux/v6.12/source/drivers/net/can/m_can/tcan4x5x-core.c#L396 Oh I really need to get my head around the dt jargon :) Yes I'll add the clock-names to the required list for v2! Br, /Sean
