On Wed, Nov 27, 2024 at 02:40:47PM +0100, Sean Nyekjaer wrote: > tcan4x5x requires an external clock called cclk, add it here. That's not what this patch is doing, the clock input is already there, so I don't know what this patch actually accomplishes? clock-names isn't a required property, so you can't even use it in a driver. > > Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml b/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml > index ff18cf7393550d1b7107b1233d8302203026579d..f3f3cbc03aec13e517552d2e29ecea1585de8e36 100644 > --- a/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml > +++ b/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml > @@ -29,6 +29,10 @@ properties: > clocks: > maxItems: 1 > > + clock-names: > + items: > + - const: cclk > + > reset-gpios: > description: Hardwired output GPIO. If not defined then software reset. > maxItems: 1 > @@ -154,6 +158,7 @@ examples: > can@0 { > compatible = "ti,tcan4x5x"; > reg = <0>; > + clock-names = "cclk"; > clocks = <&can0_osc>; > pinctrl-names = "default"; > pinctrl-0 = <&can0_pins>; > @@ -179,6 +184,7 @@ examples: > can@0 { > compatible = "ti,tcan4552", "ti,tcan4x5x"; > reg = <0>; > + clock-names = "cclk"; > clocks = <&can0_osc>; > pinctrl-names = "default"; > pinctrl-0 = <&can0_pins>; > > --- > base-commit: e0b741bc53c94f9ae25d4140202557a0aa51b5a0 > change-id: 20241127-tcancclk-c149c0b3b050 > > Best regards, > -- > Sean Nyekjaer <sean@xxxxxxxxxx> >
Attachment:
signature.asc
Description: PGP signature