On 2024/11/27 2:20, Krzysztof Kozlowski wrote: > On 26/11/2024 18:00, Sasha Finkelstein wrote: >> On Tue, 26 Nov 2024 at 17:46, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - apple,j293-summit >>>> + - apple,j493-summit >>>> + - const: apple,summit >>> >>> Summit tells me nothing - no description, title repeats it, so I suggest >>> using device specific compatible. >> >> The j293/j493 are the device-specific compatibles, those are chassis names >> for the specific laptops the panel is present in. > > This does not address my comment. Use specific compatibles as fallback, > just like we recommend for every device. This should not be different. > If you do not know the hardware details, using generic is even less > appropriate. The panel is codenamed "summit", and that tells you everything. It's a panel sold and marketed by Apple. It is used on two devices, which are specifically referred to as the device names "j293" and "j493". There is no further information to be added here, the names chosen already contain 100% of the available information and are completely and fully specific as to what devices are involved here. There is no more specific or appropriate compatible possible. "summit" literally comes from Apple's own device tree compatible in the macOS world, which is "lcd,summit". If Apple uses it as a DT compatible, then it's a good bet it is precisely what it needs to be to identify a device. The chassis-specific versions are something we added on top of that and likely aren't even necessary since it's almost certainly precisely the same exact panel in both laptops, but as you know, it's best to be specific with DT compatibles just in case. There is plenty of prior art for compatibles that don't look like random product code gobbledygook (which I think is what you were expecting?), e.g. these panels: ti,nspire-cx-lcd-panel ste,mcde-dsi raspberrypi,7inch-touchscreen-panel olimex,lcd-olinuxino focaltech,gpt3 So yeah, the correct compatible is in fact "apple,summit". Anything else would be making things up for no reason. The vendor has chosen to call this panel "summit", so "summit" it is. We're not in the business of gratuitously assigning our own product names/codes when a suitable one already exists here. - Hector
