On 26/11/2024 01:07, Dmitry Baryshkov wrote: >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>> index 590beb37f441..37c6ab217c96 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>> @@ -399,6 +399,65 @@ qfprom: efuse@780000 { >>> #size-cells = <1>; >>> }; >>> >>> + sdhc_1: mmc@7c4000 { >>> + compatible = "qcom,qcs615-sdhci", "qcom,sdhci-msm-v5"; >>> + reg = <0x0 0x007c4000 0x0 0x1000>, >>> + <0x0 0x007c5000 0x0 0x1000>; >>> + reg-names = "hc", >>> + "cqhci"; >> >> There's an "ice" region at 0x007c8000 > > Shouldn't ice now be handled by a separate device? It should and UFS bindings expect that. However I am not sure if MMC was improved to support external ICE device. Also for example on SM8550 the ICE has entirely different (further) address space, so it also suggests it is separate device. Here address space looks almost continuous. Best regards, Krzysztof