On Tue 2015-04-07 18:20:08, Bryan Wu wrote: > On Fri, Apr 3, 2015 at 1:37 PM, Pavel Machek <pavel@xxxxxx> wrote: > > Hi! > > > >> >>+- flash-timeout-us : Timeout in microseconds after which the flash > >> >>+ LED is turned off. If omitted this will default to the > >> >>+ maximum timeout allowed by the device. > >> >> > >> >> > >> >> Examples: > >> > > >> >Pavel pointed out that the brightness between maximum current and the > >> >maximum *allowed* another current might not be noticeable,leading a > >> >potential spelling error to cause the LED being run at too high current. > >> > >> Where did he point this out? Do you think about the current version > >> of the leds/common.txt documentation or there was some other message, > >> that I don't see? > > > > Date: Thu, 2 Apr 2015 22:30:44 +0200 > > From: Pavel Machek <pavel@xxxxxx> > > To: Sakari Ailus <sakari.ailus@xxxxxx> > > Subject: Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653 > > > >> Besides, I can't understand your point. Could you express it in other > >> words, please? > > > > Typo in device tree would cause hardware damage. But idea. Make the > > properties mandatory. > > Pavel > > I don't quite follow there. I think Pavel acked this patch right? So > what's left to hold here? Yeah. Then I realized that patch is wrong/dangerous. Sorry about that. Try to forget about my ACK if you can ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
