Hi Hector,
On 25/11/2024 15:24, Hector Martin wrote:
On 2024/11/25 20:24, Sasha Finkelstein wrote:
On Mon, 25 Nov 2024 at 09:50, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
So this controller only supports a single mode ???????
Most likely. On all devices it is connected to a single built-in display.
More specifically, the controller obviously supports multiple modes but
it is pre-initialized by the bootloader for the single hardwired
display's only mode. So as far as the driver is concerned, there is a
single possible mode, and there's no point in trying to be more generic
if there is no hardware that would use that.
I totally got the point, I just asked to slightly change the design to fit
the overall DRM/DSI/Panel architecture.
In general, it is not possible/practical to be generic for reverse
engineered hardware with no specs documenting how to drive it
generically. You just can't know how to implement the options that are
never used in practice. I spent a lot of time on exceptions to this rule
for the GPIO and SPI controllers, and that's not going to happen for
more complex hardware like MIPI DSI.
I'm fine with the overall actual design since it's a special usecase
for a special display present on only a few SKUs.
Nevertheless, as Maxime expressed, you should still try to fit nicely
on the abstractions, or change the abstractions.
Neil
- Hector
