On 24/11/2024 23:29, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <fnkl.kernel@xxxxxxxxx>
>
> This is the display panel used for the touchbar on laptops that have it.
...
> +static int summit_probe(struct mipi_dsi_device *dsi)
> +{
> + struct backlight_properties props = { 0 };
> + struct device *dev = &dsi->dev;
> + struct summit_data *panel;
> +
> + panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
> + if (!panel)
> + return -ENOMEM;
> +
> + mipi_dsi_set_drvdata(dsi, panel);
> + panel->dsi = dsi;
> +
> + int ret = device_property_read_u32(dev, "max-brightness", &props.max_brightness);
That's an undocumented property, which suggests you did not test your DTS.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
