On 15/11/2024 07:59, Dmitry Baryshkov wrote: > SM8450 is one of the platforms where board-level clocks (XO, sleep) are > fully defined in the SoC dtsi file. This is not correct and doesn't > fully follow the DT guidelines. Move these two clocks to the board files > completely. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 14 ++++++++++++++ > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 14 ++++++++++++++ > arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 14 ++++++++++++++ > arch/arm64/boot/dts/qcom/sm8450.dtsi | 14 -------------- > 4 files changed, 42 insertions(+), 14 deletions(-) Clocks could stay and only their frequency would be in DTS, but either way is fine: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof