On 15.11.2024 11:39 AM, Manikanta Mylavarapu wrote: > From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > > SoCs without RPM need to enable sensors and calibrate them from the kernel. > The IPQ5332 and IPQ5424 use the tsens v2.3.3 IP and do not have RPM. > Therefore, add a new calibration function for V2, as the tsens.c calib > function only supports V1. Also add new feature_config, ops and data for > IPQ5332, IPQ5424. > > Although the TSENS IP supports 16 sensors, not all are used. The hw_id > is used to enable the relevant sensors. > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx> > --- [...] > +{ > + u32 shift = V2_SHIFT_DEFAULT; > + u32 slope = V2_SLOPE_DEFAULT, czero = V2_CZERO_DEFAULT, val; Please don't mix initialized and uninitialized variables in the same line, I think it would be the cleanest if you initialized the ones you want on separate lines and then declared val separately as well (and preferably in reverse-Christmas-tree order) [...] > + } > + > + val = FIELD_PREP(CONVERSION_SHIFT_MASK, shift) | tab->space after '=' [...] > + /* Select temperature format, unit is deci-Celsius */ > + regmap_field_write(priv->rf[CODE_OR_TEMP], RSEULT_FORMAT_TEMP); "result"? Konrad