On Wed, 2024-11-20 at 01:43 -0600, Rob Herring (Arm) wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Wed, 20 Nov 2024 14:36:38 +0800, Friday Yang wrote: > > On the MediaTek platform, some SMI LARBs are directly linked to SMI > > Common. While some SMI LARBs are linked to SMI Sub Common, then SMI > > Sub Common is linked to SMI Common. The hardware block diagram > > could > > be described as below. > > Add 'resets' and 'reset-names' for SMI LARBs to support SMI reset > > and clamp operation. The SMI reset driver could get the reset > > signal > > through the two properties. > > > > SMI-Common(Smart Multimedia Interface Common) > > | > > +----------------+------------------+ > > | | | > > | | | > > | | | > > | | | > > | | | > > larb0 SMI-Sub-Common0 SMI-Sub-Common1 > > | | | | | > > larb1 larb2 larb3 larb7 larb9 > > > > Signed-off-by: Friday Yang <friday.yang@xxxxxxxxxxxx> > > --- > > > > Although this can pass the dtbs_check, maybe there is a better way > > to describe the requirements for 'resets' and 'reset-names' in > > bindings. > > But I don't find a better way to describe it that only SMI larbs > > located > > in camera and image subsys requires the 'resets' and 'reset-names'. > > I would appreciate it if you could give some suggestions. > > > > .../mediatek,smi-common.yaml | 2 + > > .../memory-controllers/mediatek,smi-larb.yaml | 53 > > +++++++++++++++---- > > 2 files changed, 44 insertions(+), 11 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/memory-controllers/mediatek,smi- > larb.yaml:143:13: [warning] wrong indentation: expected 10 but found > 12 (indentation) > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/memory- > controllers/mediatek,smi-larb.example.dts:29.43-44 syntax error > FATAL ERROR: Unable to parse input tree > make[2]: *** [scripts/Makefile.dtbs:129: > Documentation/devicetree/bindings/memory-controllers/mediatek,smi- > larb.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: > dt_binding_check] Error 2 > make: *** [Makefile:224: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241120063701.8194-2-friday.yang@xxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different > dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up > to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. > Note > that DT_SCHEMA_FILES can be set to your schema file to speed up > checking > your schema. However, it must be unset to test all examples with your > schema. > Thanks for your comments, I used to use this cmd: make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/memory- controllers/mediatek,smi-larb.yaml And I will upgrade dtschema and change to use 'make dt_binding_check' again.
