On Mon, Nov 18, 2024 at 04:26:16PM +0800, Ziyue Zhang wrote: > From: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> > > Add support for GEN3 x1 PCIe PHY found on Qualcomm QCS615 platform. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> > Signed-off-by: Ziyue Zhang <quic_ziyuzhan@xxxxxxxxxxx> > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 105 +++++++++++++++++++++ > drivers/phy/qualcomm/phy-qcom-qmp-pcs-v2.h | 1 + > 2 files changed, 106 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > index f71787fb4d7e..df82f95a1fa2 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > @@ -726,6 +726,83 @@ static const struct qmp_phy_init_tbl ipq9574_gen3x2_pcie_pcs_misc_tbl[] = { > QMP_PHY_INIT_CFG(QPHY_V5_PCS_PCIE_ENDPOINT_REFCLK_DRIVE, 0xc1), > }; > > +static const struct qmp_phy_init_tbl qcs615_pcie_serdes_tbl[] = { > + QMP_PHY_INIT_CFG(QSERDES_COM_BIAS_EN_CLKBUFLR_EN, 0x18), > + QMP_PHY_INIT_CFG(QSERDES_COM_CLK_ENABLE1, 0x10), > + QMP_PHY_INIT_CFG(QSERDES_COM_BG_TRIM, 0xf), > + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP_EN, 0x1), > + QMP_PHY_INIT_CFG(QSERDES_COM_VCO_TUNE_MAP, 0x0), > + QMP_PHY_INIT_CFG(QSERDES_COM_VCO_TUNE_TIMER1, 0xff), > + QMP_PHY_INIT_CFG(QSERDES_COM_VCO_TUNE_TIMER2, 0x1f), > + QMP_PHY_INIT_CFG(QSERDES_COM_CMN_CONFIG, 0x6), > + QMP_PHY_INIT_CFG(QSERDES_COM_PLL_IVCO, 0xf), > + QMP_PHY_INIT_CFG(QSERDES_COM_HSCLK_SEL, 0x0), > + QMP_PHY_INIT_CFG(QSERDES_COM_SVS_MODE_CLK_SEL, 0x1), > + QMP_PHY_INIT_CFG(QSERDES_COM_CORE_CLK_EN, 0x20), > + QMP_PHY_INIT_CFG(QSERDES_COM_CORECLK_DIV, 0xa), > + QMP_PHY_INIT_CFG(QSERDES_COM_RESETSM_CNTRL, 0x20), > + QMP_PHY_INIT_CFG(QSERDES_COM_BG_TIMER, 0x9), > + QMP_PHY_INIT_CFG(QSERDES_COM_SYSCLK_EN_SEL, 0x4), > + QMP_PHY_INIT_CFG(QSERDES_COM_DEC_START_MODE0, 0x82), > + QMP_PHY_INIT_CFG(QSERDES_COM_DIV_FRAC_START3_MODE0, 0x3), > + QMP_PHY_INIT_CFG(QSERDES_COM_DIV_FRAC_START2_MODE0, 0x55), > + QMP_PHY_INIT_CFG(QSERDES_COM_DIV_FRAC_START1_MODE0, 0x55), > + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP3_MODE0, 0x0), > + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP2_MODE0, 0xD), lowercase the hex. LGTM otherwise. > + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP1_MODE0, 0x04), > + QMP_PHY_INIT_CFG(QSERDES_COM_CLK_SELECT, 0x35), > + QMP_PHY_INIT_CFG(QSERDES_COM_SYS_CLK_CTRL, 0x2), > + QMP_PHY_INIT_CFG(QSERDES_COM_SYSCLK_BUF_ENABLE, 0x1f), > + QMP_PHY_INIT_CFG(QSERDES_COM_CP_CTRL_MODE0, 0x4), > + QMP_PHY_INIT_CFG(QSERDES_COM_PLL_RCTRL_MODE0, 0x16), > + QMP_PHY_INIT_CFG(QSERDES_COM_PLL_CCTRL_MODE0, 0x30), > + QMP_PHY_INIT_CFG(QSERDES_COM_INTEGLOOP_GAIN1_MODE0, 0x0), > + QMP_PHY_INIT_CFG(QSERDES_COM_INTEGLOOP_GAIN0_MODE0, 0x80), > + QMP_PHY_INIT_CFG(QSERDES_COM_BIAS_EN_CTRL_BY_PSM, 0x1), > + QMP_PHY_INIT_CFG(QSERDES_COM_BG_TIMER, 0xa), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_EN_CENTER, 0x1), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_PER1, 0x31), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_PER2, 0x1), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_ADJ_PER1, 0x2), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_ADJ_PER2, 0x0), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_STEP_SIZE1, 0x2f), > + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_STEP_SIZE2, 0x19), > + QMP_PHY_INIT_CFG(QSERDES_COM_CLK_EP_DIV, 0x19), > +}; > + > +static const struct qmp_phy_init_tbl qcs615_pcie_rx_tbl[] = { > + QMP_PHY_INIT_CFG(QSERDES_RX_SIGDET_ENABLES, 0x1c), > + QMP_PHY_INIT_CFG(QSERDES_RX_SIGDET_DEGLITCH_CNTRL, 0x14), > + QMP_PHY_INIT_CFG(QSERDES_RX_RX_EQU_ADAPTOR_CNTRL2, 0x1), > + QMP_PHY_INIT_CFG(QSERDES_RX_RX_EQU_ADAPTOR_CNTRL3, 0x0), > + QMP_PHY_INIT_CFG(QSERDES_RX_RX_EQU_ADAPTOR_CNTRL4, 0xdb), > + QMP_PHY_INIT_CFG(QSERDES_RX_UCDR_SO_SATURATION_AND_ENABLE, 0x4b), > + QMP_PHY_INIT_CFG(QSERDES_RX_UCDR_SO_GAIN, 0x4), > + QMP_PHY_INIT_CFG(QSERDES_RX_UCDR_SO_GAIN_HALF, 0x4), > +}; > + > +static const struct qmp_phy_init_tbl qcs615_pcie_tx_tbl[] = { > + QMP_PHY_INIT_CFG(QSERDES_TX_HIGHZ_TRANSCEIVEREN_BIAS_DRVR_EN, 0x45), > + QMP_PHY_INIT_CFG(QSERDES_TX_LANE_MODE, 0x6), > + QMP_PHY_INIT_CFG(QSERDES_TX_RES_CODE_LANE_OFFSET, 0x2), > + QMP_PHY_INIT_CFG(QSERDES_TX_RCV_DETECT_LVL_2, 0x12), > +}; > + > +static const struct qmp_phy_init_tbl qcs615_pcie_pcs_tbl[] = { > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_ENDPOINT_REFCLK_DRIVE, 0x4), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_OSC_DTCT_ACTIONS, 0x0), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_PWRUP_RESET_DLY_TIME_AUXCLK, 0x40), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_L1SS_WAKEUP_DLY_TIME_AUXCLK_MSB, 0x0), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_L1SS_WAKEUP_DLY_TIME_AUXCLK_LSB, 0x40), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_PLL_LOCK_CHK_DLY_TIME_AUXCLK_LSB, 0x0), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_LP_WAKEUP_DLY_TIME_AUXCLK, 0x40), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_PLL_LOCK_CHK_DLY_TIME, 0x73), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_SIGDET_CNTRL, 0x7), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_RX_SIGDET_LVL, 0x99), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_TXDEEMPH_M6DB_V0, 0x15), > + QMP_PHY_INIT_CFG(QPHY_V2_PCS_TXDEEMPH_M3P5DB_V0, 0xe), > +}; > + > static const struct qmp_phy_init_tbl sdm845_qmp_pcie_serdes_tbl[] = { > QMP_PHY_INIT_CFG(QSERDES_V3_COM_BIAS_EN_CLKBUFLR_EN, 0x14), > QMP_PHY_INIT_CFG(QSERDES_V3_COM_CLK_SELECT, 0x30), > @@ -2963,6 +3040,31 @@ static const struct qmp_phy_cfg ipq9574_gen3x2_pciephy_cfg = { > .pipe_clock_rate = 250000000, > }; > > +static const struct qmp_phy_cfg qcs615_pciephy_cfg = { > + .lanes = 1, > + > + .offsets = &qmp_pcie_offsets_v2, > + > + .tbls = { > + .serdes = qcs615_pcie_serdes_tbl, > + .serdes_num = ARRAY_SIZE(qcs615_pcie_serdes_tbl), > + .tx = qcs615_pcie_tx_tbl, > + .tx_num = ARRAY_SIZE(qcs615_pcie_tx_tbl), > + .rx = qcs615_pcie_rx_tbl, > + .rx_num = ARRAY_SIZE(qcs615_pcie_rx_tbl), > + .pcs = qcs615_pcie_pcs_tbl, > + .pcs_num = ARRAY_SIZE(qcs615_pcie_pcs_tbl), > + }, > + .reset_list = sdm845_pciephy_reset_l, > + .num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l), > + .vreg_list = qmp_phy_vreg_l, > + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), > + .regs = pciephy_v2_regs_layout, > + > + .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL, > + .phy_status = PHYSTATUS, > +}; > + > static const struct qmp_phy_cfg sdm845_qmp_pciephy_cfg = { > .lanes = 1, > > @@ -4400,6 +4502,9 @@ static const struct of_device_id qmp_pcie_of_match_table[] = { > }, { > .compatible = "qcom,msm8998-qmp-pcie-phy", > .data = &msm8998_pciephy_cfg, > + }, { > + .compatible = "qcom,qcs615-qmp-gen3x1-pcie-phy", > + .data = &qcs615_pciephy_cfg, > }, { > .compatible = "qcom,sa8775p-qmp-gen4x2-pcie-phy", > .data = &sa8775p_qmp_gen4x2_pciephy_cfg, > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcs-v2.h b/drivers/phy/qualcomm/phy-qcom-qmp-pcs-v2.h > index bf36399d0057..1ecf4b5beba6 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcs-v2.h > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcs-v2.h > @@ -34,6 +34,7 @@ > #define QPHY_V2_PCS_USB_PCS_STATUS 0x17c /* USB */ > #define QPHY_V2_PCS_PLL_LOCK_CHK_DLY_TIME_AUXCLK_LSB 0x1a8 > #define QPHY_V2_PCS_OSC_DTCT_ACTIONS 0x1ac > +#define QPHY_V2_PCS_SIGDET_CNTRL 0x1b0 > #define QPHY_V2_PCS_RX_SIGDET_LVL 0x1d8 > #define QPHY_V2_PCS_L1SS_WAKEUP_DLY_TIME_AUXCLK_LSB 0x1dc > #define QPHY_V2_PCS_L1SS_WAKEUP_DLY_TIME_AUXCLK_MSB 0x1e0 > -- > 2.34.1 > -- With best wishes Dmitry