On Mon, Nov 11, 2024 at 04:49:32PM -0800, Melody Olvera wrote: > From: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx> > > Add descriptions of pmd8028 and pmih0108 PMICs used on SM8750 > platforms. Up/lower case? > > Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx> > Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/pmd8028.dtsi | 56 +++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/pmih0108.dtsi | 62 ++++++++++++++++++++++++++ Those two are independent changes. Please use two separate patches. > 2 files changed, 118 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pmd8028.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/pmih0108.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/pmd8028.dtsi b/arch/arm64/boot/dts/qcom/pmd8028.dtsi > new file mode 100644 > index 000000000000..f8ef8e133854 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pmd8028.dtsi > @@ -0,0 +1,56 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/spmi/spmi.h> > + > +/ { > + thermal-zones { > + pmd8028-thermal { > + polling-delay-passive = <100>; > + thermal-sensors = <&pmd8028_temp_alarm>; > + > + trips { > + pmd8028_trip0: trip0 { > + temperature = <95000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + pmd8028_trip1: trip1 { > + temperature = <115000>; > + hysteresis = <0>; > + type = "hot"; "critical" ? > + }; > + }; > + }; > + }; > +}; > + > +&spmi_bus { > + pmd8028: pmic@4 { > + compatible = "qcom,pmd8028", "qcom,spmi-pmic"; > + reg = <0x4 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmd8028_temp_alarm: temp-alarm@a00 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0xa00>; > + interrupts = <0x4 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > + #thermal-sensor-cells = <0>; > + }; > + > + pmd8028_gpios: gpio@8800 { > + compatible = "qcom,pmd8028-gpio", "qcom,spmi-gpio"; > + reg = <0x8800>; > + gpio-controller; > + gpio-ranges = <&pmd8028_gpios 0 0 4>; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/qcom/pmih0108.dtsi b/arch/arm64/boot/dts/qcom/pmih0108.dtsi > new file mode 100644 > index 000000000000..3907d8fbcf78 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pmih0108.dtsi > @@ -0,0 +1,62 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/spmi/spmi.h> > + > +/ { > + thermal-zones { > + pmih0108-thermal { > + polling-delay-passive = <100>; > + thermal-sensors = <&pmih0108_temp_alarm>; > + > + trips { > + trip0 { > + temperature = <95000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <115000>; > + hysteresis = <0>; > + type = "hot"; "critical" ? > + }; > + }; > + }; > + }; > +}; > + > +&spmi_bus { > + pmih0108: pmic@7 { > + compatible = "qcom,pmih0108", "qcom,spmi-pmic"; > + reg = <0x7 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmih0108_temp_alarm: temp-alarm@a00 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0xa00>; > + interrupts = <0x7 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > + #thermal-sensor-cells = <0>; > + }; > + > + pmih0108_gpios: gpio@8800 { > + compatible = "qcom,pmih0108-gpio", "qcom,spmi-gpio"; > + reg = <0x8800>; > + gpio-controller; > + gpio-ranges = <&pmih0108_gpios 0 0 18>; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + pmih0108_eusb2_repeater: phy@fd00 { > + compatible = "qcom,pm8550b-eusb2-repeater"; > + reg = <0xfd00>; > + #phy-cells = <0>; > + }; > + }; > +}; > -- > 2.46.1 > -- With best wishes Dmitry