On Fri, Nov 15, 2024 at 1:26 AM Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > On Tue, Nov 05, 2024 at 03:32:16PM -0600, Rob Herring (Arm) wrote: > > "#interrupt-cells" is not valid without a corresponding "interrupt-map" > > or "interrupt-controller" property. As the example has neither, drop > > "#interrupt-cells". This fixes a dtc interrupt_provider warning. > > > > But the DWC controllers have an in-built MSI controller. Shouldn't we add > 'interrrupt-controller' property then? Why? Is that needed for the MSI controller to function? I don't think so. Now we do have "interrupt-controller" present for a number of MSI providers. I suspect that's there to get OF_DECLARE to work, but I doubt we really need MSI controllers initialized early. Rob