Re: [PATCH 1/2] serial: sprd: Add support for sc9632

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/11/15 15:46, wenhua lin wrote:
On Fri, Nov 15, 2024 at 1:47 PM Baolin Wang
<baolin.wang@xxxxxxxxxxxxxxxxx> wrote:



On 2024/11/13 19:05, Wenhua Lin wrote:
Due to the platform's new project uart ip upgrade,
the new project's timeout interrupt needs to use bit17
while other projects' timeout interrupt needs to use
bit13, using private data to adapt and be compatible
with all projects.

Signed-off-by: Wenhua Lin <Wenhua.Lin@xxxxxxxxxx>
---
   drivers/tty/serial/sprd_serial.c | 41 ++++++++++++++++++++++++++++----
   1 file changed, 36 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index 3fc54cc02a1f..882580c3cf37 100644
--- a/drivers/tty/serial/sprd_serial.c
+++ b/drivers/tty/serial/sprd_serial.c
@@ -53,10 +53,12 @@
   #define SPRD_IEN_TX_EMPTY   BIT(1)
   #define SPRD_IEN_BREAK_DETECT       BIT(7)
   #define SPRD_IEN_TIMEOUT    BIT(13)
+#define SPRD_IEN_DATA_TIMEOUT        BIT(17)

I don't know the meaning of 'DATA' in the new macro name. But I have no
better name now:) Otherwise look good to me.
Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

Hi baolin:
   TIMEOUT means only timeout, DATA_TIMEOUT means timeout and fifo is not empty.
   Therefore, the macro name is distinguished by adding DATA.

Good. These information should be added into commit message.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux