On Mon, Nov 11, 2024 at 09:01:33AM -0800, Guenter Roeck wrote:
> On 11/11/24 01:50, Sung-Chi wrote:
> > From: "Sung-Chi, Li" <lschyi@xxxxxxxxxxxx>
> >
> > cros_ec hwmon driver probes available thermal sensors when probing the
> > driver. Register these thermal sensors to the thermal framework, such
> > that thermal framework can adopt these sensors as well.
> >
> > To make cros_ec registrable to thermal framework, the cros_ec dts need
> > the corresponding changes:
> >
> > &cros_ec {
> > #thermal-sensor-cells = <1>;
> > };
> >
> > Change-Id: I29b638427c715cb44391496881fc61ad53abccaf
>
> Drop.
>
> > Signed-off-by: Sung-Chi, Li <lschyi@xxxxxxxxxxxx>
>
> Detailed explanation will be needed: Why not use HWMON_C_REGISTER_TZ ?
> Unless I am missing something, this code just duplicates code from the hwmon core.
>
> Please do not send follow-up patch series as response to previous ones.
>
> Guenter
>
Hi, thank you for pointing out using HWMON_C_REGISTER_TZ. After checking how
HWMON_C_REGSITER_TZ works, I think I only need to add one line into the
cros_ec_hwmon_info, and almost all concerns Thomas pointed out in latest reply
would be resolved automatically (because there would be only one line of change,
and that change is just a hwmon configuration, so should be a valid way of
combining with the thermal system).
Thank all for reviewing and giving inputs, and I will soon send out the one
line patch.
Best,
Sung-Chi, Li
