Hello Lee, this is v7 of Turris Omnia LED driver changes. v1 to v6 can be found at https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240903101930.16251-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20240913123103.21226-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20241029135621.12546-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20241104141924.18816-1-kabel@xxxxxxxxxx/ https://lore.kernel.org/linux-leds/20241108132845.31005-1-kabel@xxxxxxxxxx/ Changes since v6: - patch 6: fixed documentation comment for the @lock member of `struct omnia_leds` - patch 12: dropped, since Gregory applied it on mvebu/dt back in v5. Marek Marek Behún (11): turris-omnia-mcu-interface.h: Move command execution function to global header leds: turris-omnia: Use command execution functions from the MCU driver turris-omnia-mcu-interface.h: Add LED commands related definitions to global header leds: turris-omnia: Use global header for MCU command definitions dt-bindings: leds: cznic,turris-omnia-leds: Allow interrupts property leds: turris-omnia: Document driver private structures leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver leds: turris-omnia: Use dev_err_probe() where appropriate leds: turris-omnia: Use uppercase first letter in all comments .../leds/cznic,turris-omnia-leds.yaml | 8 + drivers/leds/Kconfig | 2 + drivers/leds/leds-turris-omnia.c | 336 +++++++++--------- .../platform/cznic/turris-omnia-mcu-base.c | 3 + drivers/platform/cznic/turris-omnia-mcu.h | 130 ------- include/linux/turris-omnia-mcu-interface.h | 148 +++++++- 6 files changed, 328 insertions(+), 299 deletions(-) -- 2.45.2