在 2024/11/12 14:43, Manivannan Sadhasivam 写道:
On Mon, Nov 11, 2024 at 09:10:39AM +0800, Shawn Lin wrote:
[...]
+static void ufs_rockchip_remove(struct platform_device *pdev)
+{
+ struct ufs_hba *hba = platform_get_drvdata(pdev);
+ struct ufs_rockchip_host *host = ufshcd_get_variant(hba);
+
+ pm_runtime_forbid(&pdev->dev);
+ pm_runtime_get_noresume(&pdev->dev);
Why do you need these? You are not incrementing the refcount in probe() and
there is no auto PM involved.
Oh, it was a leftover from former version I haven't noticed. Will
remove.
I've sent a series [1] that addresses the runtime PM issues. Could you please
give it a try and give your tested-by maybe?
Sure, I will give it a try, thanks.
- Mani
[1] https://lore.kernel.org/linux-scsi/20241111-ufs_bug_fix-v1-0-45ad8b62f02e@xxxxxxxxxx/
