Re: [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote:
> > > +		compatible = "goodix,gt911";
> > > +		reg = <0x5d>;
> > > +		interrupt-parent = <&pio>;
> > > +		interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */
> > 
> > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC
> > bindings.
> > 
>
> Hmm. Which value I must use in this case? IRQ type is set by the
> touchscreen controller driver, so I think that value must be 0.

Whatever the hardware is using. Presumably the same value than the
driver sets.

> >
> > You're also not adding a pinctrl group for that pin?
>
> No, because it works fine with this DT nodes. It seems that I should
> first configure pin to work in interrupt mode. Correct?

You don't have to, since the pio driver will already take care of
muxing it to the right function, but that will prevent any driver to
call pinctrl_request on the same pin.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux