Re: [PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/11/2024 18:03, Conor Dooley wrote:
> On Tue, Nov 05, 2024 at 03:58:14PM +0000, Matt Coster wrote:
>> +    / {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +        interrupt-controller;
>> +        #interrupt-cells = <3>;
>> +
>> +        gpu@4e20000000 {
>> +            compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
>> +            reg = /bits/ 64 <0x4e20000000 0x80000>;
> 
> Can you format this normally please? Drop the #address/size-cells down
> to 1 if you're against having 0x0s.

Sure. I thought /bits/ was the "new" way of doing things, but I'm not
really bothered either way.

Cheers,
Matt

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> 
>> +            clocks = <&k3_clks 130 1>;
>> +            clock-names = "core";
>> +            interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
>> +            power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>,
>> +                            <&k3_pds 373 TI_SCI_PD_EXCLUSIVE>;
>> +            power-domain-names = "a", "b";
>> +            dma-coherent;
>> +        };
>> +    };
>>
>> -- 
>> 2.47.0
>>

-- 
Matt Coster
E: matt.coster@xxxxxxxxxx

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux