On Mon, Nov 04, 2024 at 10:09:07AM +0100, Alexandre Ghiti wrote: > On Mon, Nov 4, 2024 at 10:05 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > > > Hi Alexandre, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on arnd-asm-generic/master] > > [also build test WARNING on robh/for-next tip/locking/core linus/master v6.12-rc6] > > [cannot apply to next-20241101] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Alexandre-Ghiti/riscv-Move-cpufeature-h-macros-into-their-own-header/20241103-230614 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master > > patch link: https://lore.kernel.org/r/20241103145153.105097-14-alexghiti%40rivosinc.com > > patch subject: [PATCH v6 13/13] riscv: Add qspinlock support > > compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202411041609.gxjI2dsw-lkp@xxxxxxxxx/ > > > > includecheck warnings: (new ones prefixed by >>) > > >> arch/riscv/include/asm/spinlock.h: asm/ticket_spinlock.h is included more than once. > > >> arch/riscv/include/asm/spinlock.h: asm/qspinlock.h is included more than once. > > Yes but that's in a #ifdef/#elif#else clause so nothing to do here! Thanks for the info, we will fix the bot. Sorry for the false positive report. > > > > > vim +10 arch/riscv/include/asm/spinlock.h > > > > 8 > > 9 #define __no_arch_spinlock_redefine > > > 10 #include <asm/ticket_spinlock.h> > > 11 #include <asm/qspinlock.h> > > 12 #include <asm/jump_label.h> > > 13 > > 14 /* > > 15 * TODO: Use an alternative instead of a static key when we are able to parse > > 16 * the extensions string earlier in the boot process. > > 17 */ > > 18 DECLARE_STATIC_KEY_TRUE(qspinlock_key); > > 19 > > 20 #define SPINLOCK_BASE_DECLARE(op, type, type_lock) \ > > 21 static __always_inline type arch_spin_##op(type_lock lock) \ > > 22 { \ > > 23 if (static_branch_unlikely(&qspinlock_key)) \ > > 24 return queued_spin_##op(lock); \ > > 25 return ticket_spin_##op(lock); \ > > 26 } > > 27 > > 28 SPINLOCK_BASE_DECLARE(lock, void, arch_spinlock_t *) > > 29 SPINLOCK_BASE_DECLARE(unlock, void, arch_spinlock_t *) > > 30 SPINLOCK_BASE_DECLARE(is_locked, int, arch_spinlock_t *) > > 31 SPINLOCK_BASE_DECLARE(is_contended, int, arch_spinlock_t *) > > 32 SPINLOCK_BASE_DECLARE(trylock, bool, arch_spinlock_t *) > > 33 SPINLOCK_BASE_DECLARE(value_unlocked, int, arch_spinlock_t) > > 34 > > 35 #elif defined(CONFIG_RISCV_QUEUED_SPINLOCKS) > > 36 > > 37 #include <asm/qspinlock.h> > > 38 > > 39 #else > > 40 > > > 41 #include <asm/ticket_spinlock.h> > > 42 > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki >
