Hi Krzysztof,
Thank you for your review!
>> +
>> + siul2: siul2@4009c000 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> e.g. pinctrl
I wasn't sure which name to pick since it's responsible for pinctrl, GPIO and, in the future,
nvmem cells. I guess I can choose pinctrl if you think it's ok.
I will address all of the other comments in v6.
Best regards,
Andrei
>
>> + compatible = "nxp,s32g2-siul2";
>> + reg = <0x4009c000 0x179c>,
>> + <0x44010000 0x17b0>;
>> + reg-names = "siul20", "siul21";
>
> Best regards,
> Krzysztof
>
