On Fri, Nov 01, 2024 at 04:27:32PM +0000, Mark Brown wrote: > On Fri, Nov 01, 2024 at 05:19:05PM +0100, Janne Grunau wrote: > > On Fri, Nov 01, 2024 at 04:08:20PM +0000, Mark Brown wrote: > > > On Fri, Nov 01, 2024 at 03:25:04PM +0100, Janne Grunau via B4 Relay wrote: > > > > > +++ b/drivers/spi/spi-apple.c > > > > @@ -0,0 +1,531 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +/* > > > > + * Apple SoC SPI device driver > > > > Please make the entire comment block a C++ one so things look more > > > intentional. > > > I did after your the same comment in v1 but reverted that since > > checkpatch.pl complained. See > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=a674fefd1732#n3742 > > > The inconsistency between *.h and *.c is surprising. I'll change it and > > ignore checkpatch.pl for v3. I'll address the other comemnts as well. > > Did you make the comment block a C++ one or a C one? The SPDX header > does need to be a C++ comment (//) for the SPDX parsers so I'm saying > make everything else also use //. There's some constraints from tools > that consume C headers but don't support the C++ syntax. err, yes. parsing error on my part. Will change the whole comment to a C++ style comment. Janne
