On Fri, Nov 01, 2024 at 04:08:20PM +0000, Mark Brown wrote: > On Fri, Nov 01, 2024 at 03:25:04PM +0100, Janne Grunau via B4 Relay wrote: > > > transfer, most of which we do not use right now. Hardware CS control > > is available, but we haven't found a way to make it stay low across > > multiple logical transfers, so we just use software CS control for now. > > It is extremely common for hardware CS control to not support multiple > transfers, I wouldn't be surprised if it's simply not possible. We > could potentially use it with compatible messages it seems dubious that > it'd be worth the time/effort of checking and using it only some of the > time. > > > +++ b/drivers/spi/spi-apple.c > > @@ -0,0 +1,531 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Apple SoC SPI device driver > > + * > > Please make the entire comment block a C++ one so things look more > intentional. I did after your the same comment in v1 but reverted that since checkpatch.pl complained. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=a674fefd1732#n3742 The inconsistency between *.h and *.c is surprising. I'll change it and ignore checkpatch.pl for v3. I'll address the other comemnts as well. Thanks, Janne
