Hi, On Fri, Oct 25, 2024 at 02:03:11PM +0200, Krzysztof Kozlowski wrote: > On Fri, Oct 25, 2024 at 07:46:43PM +0800, Charles Wang wrote: > > The Goodix GT7986U touch controller report touch data according to the > > HID protocol through the SPI bus. However, it is incompatible with > > Microsoft's HID-over-SPI protocol. > > > > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx> > > --- > > .../bindings/input/goodix,gt7986u.yaml | 71 +++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > new file mode 100644 > > index 000000000..849117639 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > @@ -0,0 +1,71 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: GOODIX GT7986U SPI HID Touchscreen > > GOODIX or Goodix? Thank you for catching this, the name should be Goodix. > > > + > > +maintainers: > > + - Charles Wang <charles.goodix@xxxxxxxxx> > > + > > +description: Supports the Goodix GT7986U touchscreen. > > + This touch controller reports data packaged according to the HID protocol, > > + but is incompatible with Microsoft's HID-over-SPI protocol. > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - goodix,gt7986u-spi > > Compatible is already documented and nothing here explains why we should > spi variant. > Ack. I will modify the compatible name based on our discussion and include an appropriate description. > > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + > > + goodix,hid-report-addr: > > I do not see this patch addressing previous review. Sending something > like this as v1 after long discussions also does not help. > > No, you keep sending the same and the same, without improvements. > I apologize for overlooking the discussions regarding this issue. I would like to clarify that while the current boards use the same address, but newly designed boards in the future may require different addresses. Retaining this property would likely offer more flexibility. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + The register address for retrieving HID report data. > > + This address is related to the device firmware and may > > + change after a firmware update. > > + > > + spi-max-frequency: true > > + > > +additionalProperties: false > > Wasn't there a comment about this as well? This goes after required: > block. > Ack, will change to unevaluatedProperties in the next version. Best regards, Charles
