Hi Tudor, On Wed, 30 Oct 2024 at 08:04, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > > > On 10/25/24 2:14 PM, Peter Griffin wrote: > > UFS Gear 4 offers faster speeds, and better power usage so lets > > enable it. > > > > Currently ufshcd_init_host_params() sets UFS_HS_G3 as a default, > > so even if the device supports G4 we end up negotiating down to > > G3. > > > > For SoCs like gs101 which have a UFS major controller version > > of 3 or above advertise Gear 4. This then allows a Gear 4 link > > on Pixel 6. > > > > For earlier controller versions keep the current default behaviour > > of reporting G3. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > > some nits/personal preferences below, no need to address them As I'm re-spinning anyways I'll update it like you suggest. Peter.
