Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm

[Matti Vaittinen <mazziesaccount@xxxxxxxxx>]

On 29/10/2024 13:11, Andreas Kemnade wrote:
> Apparently there was some confusion regarding milliohm vs. megaohm.
> (m/M). Use microohms to be able to properly specify the charger
> resistor like other drivers do. This is not used yet by mainline code
> yet. Specify a current sense resistor in milliohms range rathes then
> megaohms range in the examples.
>
> CC: sre@xxxxxxxxxx
> Reported-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@xxxxxxxxx/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>

Thanks a ton Andreas :) Maybe a
Fixes: 1af5332fcf7c ("dt-bindings: mfd: Document ROHM BD71828 bindings")
as well?

[I just pushed something like this (but untested) in my repo - but I 
missed updating the example!]

Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

> ---
>   .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml  | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> index fa17686a64f7..09e7d68e92bf 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> @@ -55,14 +55,15 @@ properties:
>       minimum: 0
>       maximum: 1
>   
> -  rohm,charger-sense-resistor-ohms:
> -    minimum: 10000000
> -    maximum: 50000000
> +  rohm,charger-sense-resistor-micro-ohms:
> +    minimum: 10000
> +    maximum: 50000
> +    default: 30000
>       description: |
>         BD71827 and BD71828 have SAR ADC for measuring charging currents.
>         External sense resistor (RSENSE in data sheet) should be used. If some
> -      other but 30MOhm resistor is used the resistance value should be given
> -      here in Ohms.
> +      other but 30mOhm resistor is used the resistance value should be given
> +      here in microohms.
>   
>     regulators:
>       $ref: /schemas/regulator/rohm,bd71828-regulator.yaml
> @@ -114,7 +115,7 @@ examples:
>               #gpio-cells = <2>;
>               gpio-reserved-ranges = <0 1>, <2 1>;
>   
> -            rohm,charger-sense-resistor-ohms = <10000000>;
> +            rohm,charger-sense-resistor-micro-ohms = <10000>;
>   
>               regulators {
>                   buck1: BUCK1 {