On Tue, Oct 29, 2024 at 03:50:41AM +0100, Andrew Lunn wrote:
> On Tue, Oct 29, 2024 at 06:43:03AM +0800, Inochi Amaoto wrote:
> > On Mon, Oct 28, 2024 at 02:09:06PM +0100, Andrew Lunn wrote:
> > > > +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> > > > @@ -210,6 +210,55 @@ i2c4: i2c@4040000 {
> > > > status = "disabled";
> > > > };
> > > >
> > > > + gmac0: ethernet@4070000 {
> > > > + compatible = "snps,dwmac-3.70a";
> > > > + reg = <0x04070000 0x10000>;
> > > > + clocks = <&clk CLK_AXI4_ETH0>, <&clk CLK_ETH0_500M>;
> > > > + clock-names = "stmmaceth", "ptp_ref";
> > > > + interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
> > > > + interrupt-names = "macirq";
> > > > + phy-handle = <&phy0>;
> > > > + phy-mode = "rmii";
> > > > + rx-fifo-depth = <8192>;
> > > > + tx-fifo-depth = <8192>;
> > > > + snps,multicast-filter-bins = <0>;
> > > > + snps,perfect-filter-entries = <1>;
> > > > + snps,aal;
> > > > + snps,txpbl = <8>;
> > > > + snps,rxpbl = <8>;
> > > > + snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> > > > + snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> > > > + snps,axi-config = <&gmac0_stmmac_axi_setup>;
> > > > + status = "disabled";
> > > > +
> > > > + mdio {
> > > > + compatible = "snps,dwmac-mdio";
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + phy0: phy@0 {
> > > > + compatible = "ethernet-phy-ieee802.3-c22";
> > > > + reg = <0>;
> > > > + };
> > > > + };
> > >
> > > It is not clear to me what cv18xx.dtsi represents,
> >
> > This is a include file to define common ip for the whole
> > cv18xx series SoCs (cv1800b, cv1812h, sg2000, sg2000).
> >
> > > and where the PHY node should be, here, or in a .dts file.
> > > Is this a SOM, and the PHY is on the SOM?
> >
> > The phy is on the SoC, it is embedded, and no external phy
> > is supported. So I think the phy node should stay here, not
> > in the dts file.
>
> So this is correct when the PHY is internal. However, this is normally
> expressed by setting phy-mode to "internal". The stmmac driver might
> however not allow that? If not, please put a comment indicating the
> PHY is part of the SoC.
>
> Andrew
Thanks, I will try "internal" and check whether it is OK, and add
a comment if not.
Regards,
Inochi
