On 10/28/24 11:13 AM, Geert Uytterhoeven wrote:
Hi Marek,
Hello Geert,
So, what would you suggest when the PHY nodes would not have compatible
strings?
I would suggest keep the PHY compatible strings, because that is the
most accurate method to describe the hardware and fulfill the PHY bring
up requirements. If the PHY changes on this hardware in some future
That issue is moot for KSZ9031.
If the PHY won't change, then we can keep the compatible strings ?
Sorry for being unclear. I should have written "the PHY bring-up
requirements are moot for KSZ9031".
Perhaps, (*) but odd erratas do show up every once in a while, so unless
you can surely say no such errata will show up for the KSZ9031, can you
really dismiss the bring up requirements ?
revision, we can revisit this discussion ? Maybe bootloader-applied DTOs
could work then ?
So, what would you suggest when the PHY nodes would not have compatible
strings?
I hope I already answered that question before.
Sorry, I may have missed that?
I really prefer not having the PHY compatible strings, as DT should
describe only what cannot be auto-detected.
See paragraph above (*). My take on this is the exact opposite, better
describe the PHY in DT fully, including compatible strings, so that if
the PHY driver needs to do some sort of bring up tweak/fix/errata
workaround/... , it can do so by matching on the compatible string
without trying to bring the PHY up in some generic and potentially
problematic way.
The MDIO bus is not discoverable the same way as PCIe or USB is, so I
don't think the "DT should describe only what cannot be detected" is
really applicable to MDIO bus the same way it applies to PCIe or USB.
