Re: [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

On Fri, Aug 2, 2024 at 7:16 PM Marek Vasut <marex@xxxxxxx> wrote:
> On 8/2/24 10:33 AM, Geert Uytterhoeven wrote:
> > What is your stance on this?

> > On Thu, Jul 4, 2024 at 5:26 PM Niklas Söderlund
> > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> >> When creating a dedicated mdio node to describe the bus the gpio reset
> >> property was erroneously left in the phy node. The reason for adding
> >> mdio nodes on WhiteHawk was to ensure the PHYs where reset before they
> >> were probed, keeping the property in the phy node prevented this.
>
> If the PHYs should be reset before they are probed, that is something
> the PHY driver should take care of, right ? The PHY driver can bind to
> the PHY via compatible string. Does the PHY driver not reset the PHYs ?

AFAIK, there is no requirement to reset the PHY before it is probed.
However, the reset signal may be in asserted state when the PHY is
probed (e.g. after unbind from the Ethernet driver, or during kexec).
Identifying the PHY by reading the ID register requires deasserting
the reset first.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux