Hi Linus,
On 25.10.24 21:32, Linus Walleij wrote:
...
On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
The way of implementing a flip option follows the existing
panel-samsung-s6e8aa0.c [1][2][3].
That driver is notoriously hard to read because it uses so much
magic numbers so please don't copy that aspect of the driver.
Actually I used that same approach for the flip option. The
implementation of flip looked very well to me. I wanted to state it as
source in the commit message. I don't feel comfortable without declaring it.
(...)
+ if (ctx->flip_horizontal)
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcb, 0x0e);
#define S6E88A0_SET_FLIP 0xcb
or something like this.
The 0xcb command register might be more a general panel control, not
only serving panel flip. But I can't say for sure. Translating single
commands to command register names becomes too arbitrary.
...
Kind regards,
Jakob
