Hi Jakob, thanks for your patch! On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: > The way of implementing a flip option follows the existing > panel-samsung-s6e8aa0.c [1][2][3]. That driver is notoriously hard to read because it uses so much magic numbers so please don't copy that aspect of the driver. (...) > + if (ctx->flip_horizontal) > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcb, 0x0e); #define S6E88A0_SET_FLIP 0xcb or something like this. Other than that it looks good! Yours, Linus Walleij
