On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> Add support for sound (headphones and mics only)
> Also redefine slpi reserved memory, because adsp_mem overlaps with
> slpi_mem inherited from sdm845.dtsi.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
>
> ---
[...]
> +&sound {
> + compatible = "qcom,sdm845-sndcard";
> + model = "Samsung Galaxy S9";
Are spaces cool with userspace?
> + pinctrl-0 = <&quat_mi2s_active &quat_mi2s_sd0_active &quat_mi2s_sd1_active>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + audio-routing = "RX_BIAS", "MCLK",
> + "AMIC2", "MIC BIAS2", /* Headset Mic */
> + "AMIC3", "MIC BIAS2", /* FMLeft Tx */
> + "AMIC4", "MIC BIAS2", /* FMRight Tx */
> + "DMIC0", "MIC BIAS1", /* Digital Mic0 */
> + "DMIC5", "MIC BIAS4", /* Digital Mic1 */
> + "DMIC4", "MIC BIAS4", /* Digital Mic2 */
> + "DMIC3", "MIC BIAS3", /* Digital Mic3 */
> + "DMIC2", "MIC BIAS3", /* Digital Mic4 */
> + "DMIC1", "MIC BIAS1"; /* Digital Mic5 */
> +
> + mm1-dai-link {
> + link-name = "MultiMedia1";
> + cpu {
Please add a newline before subnodes
[...]
> +
> + codec {
> + sound-dai = <&wcd9340 2>; /* AIF2_PB */
It would be nice to create a binding for wcd9340, like
include/dt-bindings/sound/qcom,wcd9335.h
Konrad
