On 18.10.2024 4:54 AM, Alexey Klimov wrote:
> Add sound node and dsp-related piece to enable HDMI audio
> playback support on Qualcomm QRB4210 RB2 board. That is the
> only sound output supported for now.
>
> The audio playback is verified using the following commands:
>
> amixer -c0 cset iface=MIXER,name='SEC_MI2S_RX Audio Mixer MultiMedia1' 1
> aplay -D hw:0,0 /usr/share/sounds/alsa/Front_Center.wav
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 55 ++++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1888d99d398b..5f671b9c8fb9 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -6,6 +6,8 @@
> /dts-v1/;
>
> #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> +#include <dt-bindings/sound/qcom,q6asm.h>
> #include <dt-bindings/usb/pd.h>
> #include "sm4250.dtsi"
> #include "pm6125.dtsi"
> @@ -103,6 +105,51 @@ led-wlan {
> };
> };
>
> + sound {
> + compatible = "qcom,qrb4210-rb2-sndcard";
> + pinctrl-0 = <&lpi_i2s2_active>;
> + pinctrl-names = "default";
> + model = "Qualcomm-RB2-WSA8815-Speakers-DMIC0";
> + audio-routing = "MM_DL1", "MultiMedia1 Playback",
> + "MM_DL2", "MultiMedia2 Playback";
I'm seeing a lot of double spaces in this patch
> +
> + mm1-dai-link {
> + link-name = "MultiMedia1";
> + cpu {
Please add a newline between the subnode
Looks nice otherwise
Konrad
