On 17.10.2024 12:27 PM, YijieYang wrote: > From: Yijie Yang <quic_yijiyang@xxxxxxxxxxx> > > Enable the SerDes PHY on qcs8300-ride. > Add the MDC and MDIO pin functions for ethernet0 on qcs8300-ride. > Enable the first 1Gb ethernet port on qcs8300-ride development board. > > Signed-off-by: Yijie Yang <quic_yijiyang@xxxxxxxxxxx> > --- [...] > + > +&tlmm { > + ethernet0_default: ethernet0-default-state { > + ethernet0_mdc: ethernet0-mdc-pins { If you don't intend to modify these specific configs, you can drop the labels from child pin nodes The rest looks good Generally refactors happen first and features are added later, but I know how painful it is to reorder changes in a patchset, so I'm not going to ask you to do that. Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> Konrad