Hi Geert,
On 10/22/24 14:36, Geert Uytterhoeven wrote:
On Tue, Oct 8, 2024 at 11:14 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
When CONFIG_ENERGY_MODEL=y, an error is printed on RZ/G2E and R-Car E3:
cpu cpu0: EM: invalid perf. state: -22
This happens because the Operating Points Parameters tables do not list
voltages, as they are all identical. Previously, it was assumed they
were optional, and unused, when none of the CPU nodes is tied to a
regulator using the "cpu-supply" property. This assumption turned out
to be incorrect, causing the reported error message.
This RFC patch series fixes this by adding the missing voltages.
Note that the Energy Model calculates energy efficiency by dividing the
(estimated) CPU power consumption by CPU core clock frequency. When all
voltages have the same value, the former is proportional to clock
frequency, and energy efficiency becomes a constant. Hence all
operating points are considered to have the same efficiency, and the
Energy Model always picks the one with the highest clock rate (see also
[1]).
Alternatively, the Energy Model could be changed to silently ignore OPP
tables with missing frequencies. IMHO this is not an unusual case.
Which approach should be taken?
Thanks for your comments!
Any comments from the Energy Model and PM people?
My apologies for delay.
So you had issue with bogus Voltage values and removed them.
There is another way to setup EM properly, via DT:
"opp-microwatt" [1].
That micro watt value won't confuse other subsystems, like
your regulator fwk. It will only be used by the EM fwk.
This would be an alternative to your voltage values.
Sounds better to you?
Do you know from /sys/kernel/debug/energy_model/
the current power values?
Regards,
Lukasz
[1]
https://www.kernel.org/doc/html/v6.11/power/energy-model.html#registration-of-em-using-dt
