Hi Frank,
On Wed, Oct 23, 2024 at 11:07 PM Frank Li <Frank.Li@xxxxxxx> wrote:
> Fix the issue where both 'output-low' and 'output-high' exist under GPIO
> hog nodes (rst_usb_hub_hog and sel_usb_hub_hog) when applying device
> tree overlays. Since /delete-property/ is not supported in the overlays,
> setting 'output-low' results in both properties being present. The
> workaround is to disable these hogs and create new ones with 'output-low'
> as needed.
>
> Fix below CHECK_DTBS warning:
> arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtb: sel-usb-hub-hog:
> {'output-low': True, 'gpio-hog': True, 'gpios': [[1, 0]], 'output-high': True, 'phandle': 108, '$nodename': ['sel-usb-hub-hog']}
> is valid under each of {'required': ['output-low']}, {'required': ['output-high']
>
> Fixes: 3f6fc30abebc ("arm64: dts: imx8mn: tqma8mqnl-mba8mx: Add USB DR overlay")
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> Alex:
> I have not hardware to run it. I check dtb output is correct.
> ---
> .../imx8mn-tqma8mqnl-mba8mx-usbotg.dtso | 29 +++++++++++++++++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtso b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtso
> index 96db07fc9bece..1f2a0fe70a0a2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtso
> @@ -29,12 +29,37 @@ usb_dr_connector: endpoint {
> };
> };
>
> +/*
> + * rst_usb_hub_hog and sel_usb_hub_hog have property 'output-high',
> + * dt overlay don't support /delete-property/. Both 'output-low' and
> + * 'output-high' will be exist under hog nodes if overlay file set
> + * 'output-low'. Workaround is disable these hog and create new hog with
> + * 'output-low'.
> + */
> +
> &rst_usb_hub_hog {
> - output-low;
> + status = "disabled";
> +};
> +
> +&expander0 {
> + rst-usb-low-hub-hog {
> + gpio-hog;
> + gpios = <13 0>;
> + output-low;
> + line-name = "RST_USB_HUB#";
> + };
> };
>
> &sel_usb_hub_hog {
> - output-low;
> + status = "disabled";
> +};
> +
> +&gpio2 {
> + sel-usb-low-hub-hog {
> + gpio-hog;
> + gpios = <1 GPIO_ACTIVE_HIGH>;
> + output-low;
> + };
> };
>
> &usbotg1 {
Note that after this, there is still
/delete-property/ disable-over-current;
left, which does not actually remove the property.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
