On Fri, Oct 25, 2024 at 12:59:54PM +0200, Christian Marangi wrote: > On Wed, Oct 23, 2024 at 06:53:14PM +0200, Andrew Lunn wrote: > > > + /* Enable Asymmetric Pause Capability */ > > > + ret = phy_set_bits(phydev, MII_ADVERTISE, ADVERTISE_PAUSE_ASYM); > > > + if (ret) > > > + return ret; > > > > The PHY driver alone does not decide this. The MAC driver needs to > > indicate it supports asym pause by calling phy_supports_asym_pause(). > > > > Sorry for the stupid question, I couldn't find this OPs. Any hit how to > handle this? For phylink, set MAC_ASYM_PAUSE | MAC_SYM_PAUSE in the capabilities in phylink_config. For phylib, call phy_support_asym_pause(phydev) after connecting to the PHY. Andrew
