> + /* Enable Asymmetric Pause Capability */ > + ret = phy_set_bits(phydev, MII_ADVERTISE, ADVERTISE_PAUSE_ASYM); > + if (ret) > + return ret; The PHY driver alone does not decide this. The MAC driver needs to indicate it supports asym pause by calling phy_supports_asym_pause(). > + > + /* Disable EEE */ > + ret = phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); > + if (ret) > + return ret; Again, the core code should handle this, unless EEE is broken and you need to force it off. Andrew
