On 9/23/2024 5:14 AM, Marc Kleine-Budde wrote: > On 22.09.2024 22:51:49, Hal Feng wrote: > > From: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> > > > > Add driver for CAST CAN Bus Controller used on StarFive JH7110 SoC. > > Have you read me review of the v1 of this series? > > https://lore.kernel.org/all/20240129-zone-defame-c5580e596f72- > mkl@xxxxxxxxxxxxxx/ Yes, I modify accordingly except using FIELD_GET() / FIELD_PREP(), using rx_offload helper and the shared interrupt flag. I found FIELD_GET() / FIELD_PREP() can only be used when the mask is a constant, and the CAN module won't work normally if I change the interrupt flag to 0. I will try to using rx_offload helper in the next version. Best regards, Hal
